Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define install_folder to be usable by custom generators #5569

Merged

Conversation

@memsharded
Copy link
Member

commented Aug 1, 2019

Changelog: BugFix: Fix crash with custom generators using install_folder
Docs: Omit

Close #5568

@tags: slow

@lasote
lasote approved these changes Aug 2, 2019
@memsharded memsharded added this to the 1.19 milestone Aug 2, 2019
@sarikakaran sarikakaran added this to To Do in Test Aug 5, 2019
@sarikakaran sarikakaran removed this from To Do in Test Aug 5, 2019
@jgsogo

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Please, solve the conflicts, update the changelog/docs and I think it can be merged. IMO the current documentation is good enough:

install_folder

The folder in which the installation of packages outputs the generator files with the information of dependencies. By default in the the local cache its value is the same as self.build_folder one.

When executing Conan commands in the Package development flow like conan install or conan build, this attribute will be pointing to the folder specified in the command line.

@memsharded memsharded merged commit a8f99c3 into conan-io:develop Aug 12, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@memsharded memsharded deleted the memsharded:feature/install_folder_generators branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.