Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shallow copy: 1.18.1 #5571

Merged
merged 4 commits into from Aug 2, 2019
Merged

Conversation

@lasote
Copy link
Contributor

@lasote lasote commented Aug 2, 2019

Changelog: Bugfix: The scm feature was trying to run a checkout after a shallow clone.
Docs: omit

Closes #5570
Closes #5587

@tags: svn, slow
@revisions: 1

SSE4
SSE4 approved these changes Aug 2, 2019
Copy link
Member

@jgsogo jgsogo left a comment

It is looking good 👍

conans/test/functional/scm/scm_test.py Outdated Show resolved Hide resolved
conans/test/functional/scm/scm_test.py Outdated Show resolved Hide resolved
conans/client/tools/scm.py Outdated Show resolved Hide resolved
jgsogo
jgsogo approved these changes Aug 2, 2019
Copy link
Member

@jgsogo jgsogo left a comment

🤞 🍔 x2

@jgsogo jgsogo added this to the 1.18.1 milestone Aug 2, 2019
@lasote lasote merged commit 3f03391 into conan-io:release/1.18.1 Aug 2, 2019
2 checks passed
AKhranovskiy pushed a commit to AKhranovskiy/conan that referenced this issue Sep 2, 2019
* Fix shallow copy

* Keep checkout calling submodules checkout

* More complete test, fixed else

* Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants