Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call post_package hook before computing the manifest #5647

Merged
merged 5 commits into from Aug 20, 2019

Conversation

@jgsogo
Copy link
Member

commented Aug 19, 2019

Changelog: Fix: Call post_package hook before computing the manifest
Docs: omit

With this PR the hook post_package runs before computing the manifest, so example here would work as documented:

 import os
 from conans import tools

 SIGNATURE = "this is my signature"

 def post_package(output, conanfile, conanfile_path, **kwargs):
     sign_path = os.path.join(conanfile.package_folder, ".sign")
     tools.save(sign_path, SIGNATURE)
     output.success("Package signed successfully")

closes #5588

@jgsogo jgsogo added this to the 1.19 milestone Aug 19, 2019
@jgsogo jgsogo self-assigned this Aug 19, 2019
@jgsogo jgsogo requested a review from danimtb Aug 19, 2019
@jgsogo jgsogo assigned lasote and unassigned jgsogo Aug 19, 2019
@lasote
lasote approved these changes Aug 20, 2019
Copy link
Contributor

left a comment

A test checking that the manifest contains a newly introduced file would be comforting.

@jgsogo

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

Ok, I'll add a file to the package_folder in the hook and check that it appears in the manifest 👍

@lasote lasote merged commit 42e688e into conan-io:develop Aug 20, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@jgsogo jgsogo deleted the jgsogo:bug/5580-post_package-before-manifest branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.