Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Opt-out for Git shallow clone in SCM feature #5677
memsharded left a comment
I agree with @lasote that the code could be simpler making it less generic, by assuming a default of strings, and just handling the corner cases of bools and ints explictly. At some points it becomes a bit difficult to read for the value.
However, it seems correct, lets move it forward now that we need to release 1.18.2, and @jgsogo will pay for