Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed anonymous access with Artifactory #5688

Merged
merged 3 commits into from Aug 30, 2019

Conversation

@lasote
Copy link
Contributor

commented Aug 29, 2019

Changelog: Bugfix: When Artifactory doesn't have the anonymous access activated, the conan client wasn't able to capture the server capabilities and therefore never used the revisions mechanism.
Docs: omit

Closes #5687

@revisions: 1

@lasote lasote added this to the 1.18.2 milestone Aug 29, 2019

@lasote lasote requested a review from memsharded Aug 29, 2019

lasote added 2 commits Aug 29, 2019
@@ -123,7 +123,7 @@ def test_trace_actions(self):
self.assertEqual(num_post, 2) # 2 get urls

num_get = len([it for it in actions if "REST_API_CALL" in it and "GET" in it])
self.assertEqual(num_get, 10)
self.assertEqual(num_get, 9)

This comment has been minimized.

Copy link
@lasote

lasote Aug 29, 2019

Author Contributor

We save a "ping" (counted only when the call doesn't raise 401), because we fail sooner to authenticate:

0 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/users/authenticate'
1 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/ping'
2 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/conans/Hello0/0.1/lasote/stable/packages/d3f1f0cd90ebac9640b57627a960c07e557d3cca/download_urls'
3 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/ping'
4 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/conans/Hello0/0.1/lasote/stable/digest'
5 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/users/check_credentials'
6 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/conans/Hello0/0.1/lasote/stable'
7 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/users/check_credentials'
8 = {str} 'http://fake2d36cd11d8974824a04482cf91991095.com/v1/conans/Hello0/0.1/lasote/stable/packages/d3f1f0cd90ebac9640b57627a960c07e557d3cca'

Previously:

00 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/ping'
01 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/users/authenticate'
02 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/ping'
03 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/conans/Hello0/0.1/lasote/stable/packages/d3f1f0cd90ebac9640b57627a960c07e557d3cca/download_urls'
04 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/ping'
05 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/conans/Hello0/0.1/lasote/stable/digest'
06 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/users/check_credentials'
07 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/conans/Hello0/0.1/lasote/stable'
08 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/users/check_credentials'
09 = {str} 'http://fake1fe511ccdec1410a98066be81b858270.com/v1/conans/Hello0/0.1/lasote/stable/packages/d3f1f0cd90ebac9640b57627a960c07e557d3cca'

@lasote lasote merged commit 85f5232 into conan-io:release/1.18.2 Aug 30, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
AKhranovskiy pushed a commit to AKhranovskiy/conan that referenced this pull request Sep 2, 2019
Fixed anonymous access with Artifactory (conan-io#5688)
* Fixed anonymous access with Artifactory

* Better comment

* Fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.