Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Version ranges resolution using references without user/channel #5707

Merged

Conversation

@jgsogo
Copy link
Member

commented Sep 4, 2019

Changelog: Fix: Version ranges resolution using references without user/channel
Docs: omit

It was using str for the references from the folders and the pattern (libB/*@_/_) was not able to match them.

@memsharded

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Interesting. If true, it might deserve a 1.18.3

@jgsogo jgsogo force-pushed the jgsogo:fix/version_ranges-no_userchannel branch from 155abc3 to 42ea6ec Sep 4, 2019

@jgsogo jgsogo requested a review from lasote Sep 5, 2019

@jgsogo jgsogo marked this pull request as ready for review Sep 5, 2019

@jgsogo jgsogo changed the base branch from develop to release/1.18.3 Sep 5, 2019

@jgsogo jgsogo force-pushed the jgsogo:fix/version_ranges-no_userchannel branch from 6de3b60 to 5dcf45c Sep 5, 2019

@memsharded memsharded added this to the 1.18.3 milestone Sep 5, 2019

@lasote
lasote approved these changes Sep 9, 2019

@lasote lasote merged commit b056669 into conan-io:release/1.18.3 Sep 9, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@jgsogo jgsogo deleted the jgsogo:fix/version_ranges-no_userchannel branch Sep 9, 2019

@lasote lasote removed their assignment Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.