Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override version ranges from downstream consumers #5713

merged 10 commits into from Oct 24, 2019


Copy link

@jgsogo jgsogo commented Sep 5, 2019

Changelog: Bugfix: Downstream overrides to exact dependencies versions are always used, even if the upstream has a version range that does not satisfy the override.
Docs: Omit

Related to #5507

Copy link
Member Author

@jgsogo jgsogo commented Sep 9, 2019


  • if the override comes from a version range, the check is performed and it should raise if it doesn't satisfy.
  • if the override comes from a full reference, no check.

@@ -13,26 +13,3 @@ def verbose_version_test(self):{CONANFILE: str(conanfile)})"install . --build", assert_error=True)
self.assertIn("from requirement 'MyOtherPkg/[~0.1]@user/testing'", client.out)

def werror_fail_test(self):
Copy link
Member Author

@jgsogo jgsogo Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is duplicated in the new ones. It adds no value now.

@jgsogo jgsogo marked this pull request as ready for review Sep 9, 2019
@lasote lasote assigned memsharded and unassigned jgsogo Sep 10, 2019
Copy link
Member Author

@jgsogo jgsogo commented Sep 12, 2019

I'll add some checks for CONAN_ERROR_ON_OVERRIDE

Copy link
Member Author

@jgsogo jgsogo commented Sep 12, 2019

Checked, no need to add more tests. As long as the message "requirement libB/[<=2.0]@user/channel overridden by your conanfile to libB/1.0@user/channel" is written, the warning will turn into an error with CONAN_ERROR_ON_OVERRIDE=True.

@lasote lasote added this to the 1.20 milestone Sep 25, 2019
Copy link

@lasote lasote commented Oct 2, 2019

For 1.20. Discuss what we want, if something is breaking etc.

@memsharded memsharded merged commit 3ee0398 into conan-io:develop Oct 24, 2019
2 checks passed
@jgsogo jgsogo deleted the fix/5507-override-version-ranges branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants