Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print similar commands on the unknown command error #5725

Merged
merged 5 commits into from Sep 11, 2019

Conversation

@Minimonium
Copy link
Contributor

@Minimonium Minimonium commented Sep 9, 2019

Changelog: Feature: Show suggestions when typing an incorrect command conan command.
Docs: omit

Closes #5724

@Minimonium
Copy link
Contributor Author

@Minimonium Minimonium commented Sep 9, 2019

Oh, snap. I think I broke some tests by uplifting the Python 2 warning?

Copy link
Member

@memsharded memsharded left a comment

Please add a test for this new functionality, ask for help if needed. Thanks for your contribution!

conans/client/command.py Outdated Show resolved Hide resolved
conans/client/command.py Outdated Show resolved Hide resolved
@Minimonium Minimonium force-pushed the feature/helpful-unknown-command branch from 9980ce0 to 83e4322 Sep 10, 2019
@memsharded memsharded added this to the 1.19 milestone Sep 10, 2019
lasote
lasote approved these changes Sep 11, 2019
Copy link
Contributor

@lasote lasote left a comment

Fantastic!

@lasote lasote merged commit e6e631e into conan-io:develop Sep 11, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants