Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAccept logging level names (#5765) #5772
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
Seems like the parallel test has some fragility. I can't reproduce the same behavior when running virtual env on my machine. |
This comment has been minimized.
This comment has been minimized.
|
The functional tests was contaminated by env vars. |
| self.assertEqual(logging.DEBUG, config.logging_level) | ||
|
|
||
| def test_log_level_numbers_invalid(self): | ||
| save(os.path.join(self.tmp_dir, CONAN_CONF), default_client_conf_log.format("level = wakawaka")) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
Sep 25, 2019
Author
Member
from early condition, any error is treated as default logging level (CRITICAL). Should we change it?
This comment has been minimized.
This comment has been minimized.
uilianries
Sep 25, 2019
Author
Member
The condition is here: https://github.com/conan-io/conan/blob/1.18.5/conans/client/conf/__init__.py#L511
| @@ -506,7 +507,8 @@ def logging_level(self): | |||
| if level is None: | |||
| level = self.get_item("log.level") | |||
| try: | |||
| level = int(level) | |||
| parsed_level = get_log_level_by_name(level) | |||
| level = parsed_level if parsed_level is not None else int(level) | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
Let's go ahead with this little change, I always have to think about the pairing between numbers and log-levels. |
This comment has been minimized.
This comment has been minimized.
|
@jgsogo all yours. |
|
Please, @uilianries, consider these changes to keep the environment modification local to the test-case (uilianries#15) and I'll merge |
Keep environment modification local to the testcase
This comment has been minimized.
This comment has been minimized.
|
@jgsogo Done, it has been merged! |
|
Perfect. Now move to the docs, we have the opportunity to improve them a little bit |
uilianries commentedSep 19, 2019
•
edited
Now any user can set Conan logging level using common names as debug, info, critical ...
Related Issue: #5765
Changelog: Feature: Accept logging level as logging names
Docs: conan-io/docs#1419
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.