Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/5783 #5832

Merged
merged 22 commits into from Sep 27, 2019

Conversation

@czoido
Copy link
Contributor

commented Sep 27, 2019

Changelog: Bugfix: Set Ninja to use cpu_count value when building with parallel option with CMake
Docs: omit

Ninja generator in CMake was being omitted when the parallel option was set to True when using CMake build helper. This PR fixes that behavior.

Closes #5783

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant

This comment has been minimized.

Copy link

commented Sep 27, 2019

CLA assistant check
All committers have signed the CLA.

@lasote lasote added this to the 1.19 milestone Sep 27, 2019
@czoido czoido force-pushed the czoido:issue/5783 branch from db1c693 to 163812b Sep 27, 2019
@lasote
lasote approved these changes Sep 27, 2019
@memsharded memsharded merged commit 2625d00 into conan-io:develop Sep 27, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.