Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conanfile set_name() and set_version() #5881

Merged
merged 15 commits into from Oct 23, 2019

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Oct 8, 2019

Changelog: Feature: New set_name() and set_version() member methods to dynamically obtain the name and version (at export time).
Docs: conan-io/docs#1444

  • Convert the load_class() method so it always returns a conanfile object, not just the class
  • Rename the Loader methods to something more consistent. Extract common code to load_named() method.
  • Remove the weird skipping of inheriting the name and version for python-requires (supersedes #5882)
  • Propose the get_name() and get_version() methods

#tags: slow, svn

@memsharded memsharded changed the title trying to manage always objects Conanfile get_name() and get_version() Oct 16, 2019
@memsharded memsharded marked this pull request as ready for review Oct 16, 2019
@memsharded memsharded added this to the 1.20 milestone Oct 16, 2019
@memsharded memsharded self-assigned this Oct 17, 2019
@memsharded memsharded requested a review from lasote Oct 17, 2019
lasote
lasote approved these changes Oct 18, 2019
@lasote lasote removed their assignment Oct 18, 2019
@memsharded
Copy link
Member Author

@memsharded memsharded commented Oct 18, 2019

Completed with refactors, more testing and docs.

@memsharded memsharded assigned lasote and unassigned memsharded Oct 19, 2019
@memsharded memsharded changed the title Conanfile get_name() and get_version() Conanfile set_name() and set_version() Oct 22, 2019
@lasote lasote merged commit eabb99e into conan-io:develop Oct 23, 2019
2 checks passed
@memsharded memsharded deleted the feature/conanfile_objects branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants