Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store checksum of downloaded (and uploaded) packages #5910

merged 61 commits into from Oct 28, 2019


Copy link

@czoido czoido commented Oct 15, 2019

Changelog: Feature: Store md5 and sha1 checksums of downloaded and uploaded packages in metadata.json.
Docs: omit

Closes #5734

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

czoido and others added 30 commits Apr 4, 2019
* apply graph_lock before looking for overrides

* first step: get rid of the warning

* cleaner if graph_lock is passed to the function

* only update requires upstream if no lockfile is applied

* fix tests

* if CONAN_USERNAME and CONAN_CHANNEL are deprecated, the error cannot recommend them

* update tests accordingly
* no user/channel repr without _

* minor fixes

* fix tests
* Refresh token client support. Missing tests. Missing migration

* public method


* Refresh almost there

* Removed prints

* Try migrate

* Migration

* Add comment

* Refresh token flow following RFC recommentations

* Refresh ok

* review

* Remove traces

* Refactor capabilities

* Removed tmp file

* Review
* conan-io#5819 Show warning message for Python 3.4

- Add new warning message for python 3.4 which is no longer supported
- Added funcional tests to validate both python 3.4 and 2.x

Signed-off-by: Uilian Ries <>

* conan-io#5819 Fix broken tests

Signed-off-by: Uilian Ries <>
* Add to cmake generators

* Fix unit tests to mimic real behavior

* cmake_paths test

* add test for cmake generator

* Add cmake_find_package test

* fix test in py3

* Applied to pkg_config generator

* check different name in pkg_config
@lasote lasote added this to the 1.20 milestone Oct 15, 2019
@lasote lasote self-assigned this Oct 15, 2019
Copy link

@lasote lasote left a comment

Probably you are right and the metadata is good enough. Go ahead.

conans/client/ Show resolved Hide resolved
@czoido czoido marked this pull request as ready for review Oct 15, 2019
@czoido czoido force-pushed the checksum_packages/5734 branch from e7e7be9 to 792c71a Oct 17, 2019
conans/client/cmd/ Outdated Show resolved Hide resolved
conans/test/functional/command/ Show resolved Hide resolved
@czoido czoido requested a review from lasote Oct 22, 2019
@memsharded memsharded self-assigned this Oct 22, 2019
@lasote lasote removed their assignment Oct 23, 2019
@lasote lasote requested a review from memsharded Oct 23, 2019
lasote approved these changes Oct 23, 2019
conans/client/ Outdated Show resolved Hide resolved
conans/test/functional/command/ Outdated Show resolved Hide resolved
@czoido czoido merged commit 0063d9a into conan-io:develop Oct 28, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants