Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Don't use override dependencies as public dependency for CMake #5945

Merged
merged 2 commits into from Oct 20, 2019

Conversation

@climblinne
Copy link
Contributor

climblinne commented Oct 19, 2019

Changelog: Bugfix: Fixed bug when overriden dependencies that don't exist and make the CMake generated code crash
Docs: Omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Close #5680

@climblinne

This comment has been minimized.

Copy link
Contributor Author

climblinne commented Oct 19, 2019

A sample project to reproduce the issue could be found in #5680

@memsharded memsharded added this to the 1.20 milestone Oct 20, 2019
@memsharded memsharded self-assigned this Oct 20, 2019
@memsharded

This comment has been minimized.

Copy link
Member

memsharded commented Oct 20, 2019

Excellent investigation, thanks for submitting the fix!

I have contributed a test, based on your reproducible sample project, thanks for it too.

@memsharded memsharded merged commit 61e1eff into conan-io:develop Oct 20, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@memsharded

This comment has been minimized.

Copy link
Member

memsharded commented Oct 20, 2019

Merged. Will be released in 1.20.

@climblinne climblinne deleted the climblinne:issue-5680 branch Oct 21, 2019
@memsharded memsharded modified the milestones: 1.20, 1.19.3 Oct 25, 2019
@memsharded

This comment has been minimized.

Copy link
Member

memsharded commented Oct 25, 2019

Backporting this to 1.19.3, will be released today or tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.