Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6029 Force Six version to 1.12.0 #6031

Merged

Conversation

@uilianries
Copy link
Member

uilianries commented Nov 6, 2019

This is another alternative for #6029. If you don't want to wait for Astroid release, we can force Six version.

Changelog: Bugfix: Fix Six package version to be compatible with Astroid
Docs: Omit
fixes #6029

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@lasote

This comment has been minimized.

Copy link
Contributor

lasote commented Nov 6, 2019

This affects also to, at least, 1.17, 1.18, 1.19... So not sure if releasing a minor of 1.20 is going to fix something.

@lasote lasote merged commit 476032e into conan-io:release/1.20.2 Nov 6, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@bldrvnlw

This comment has been minimized.

Copy link

bldrvnlw commented Nov 6, 2019

Is there a recommended workaround while we are waiting for the 1.20.2? (I have an appveyor windows build failing due to this.)
@lasote @uilianries Thanks for all your work on this great product!

@jgsogo

This comment has been minimized.

Copy link
Member

jgsogo commented Nov 6, 2019

@bldrvnlw the better workaround I can think about is installing yourself pip install six==1.12.0 before installing Conan. Conan will find a valid six, won't install it and astroid will be satisfied too.

So, in your appveyor:

...
pip install six==1.12.0
pip install conan
...
@bldrvnlw

This comment has been minimized.

Copy link

bldrvnlw commented Nov 6, 2019

@jgsogo Thanks!

@lasote lasote added this to the 1.20.2 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.