Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require user input to continue working with Python 2 #6336

Merged
merged 8 commits into from Jan 15, 2020

Conversation

jgsogo
Copy link
Member

@jgsogo jgsogo commented Jan 10, 2020

Changelog: Feature: Force the user to read that Python 2 has been deprecated.
Docs: conan-io/docs#1523

closes #6170

image

@jgsogo jgsogo added this to the 1.22 milestone Jan 10, 2020
@jgsogo jgsogo self-assigned this Jan 10, 2020
@jgsogo jgsogo requested a review from czoido Jan 13, 2020
@jgsogo jgsogo marked this pull request as ready for review Jan 13, 2020
czoido
czoido approved these changes Jan 14, 2020
Copy link
Member

@memsharded memsharded left a comment

Please see the comment, do a PR to the docs and this can be merged.

self._out.writeln("*"*width, front=Color.BRIGHT_RED)

self._out.writeln(textwrap.fill("Python 2 is deprecated as of 01/01/2020 and Conan has"
" stopped supporting it oficially. We strongly recommend"
Copy link
Member

@memsharded memsharded Jan 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add something like "Conan will completely stop working with Python2 in the following months"

Copy link
Member

@uilianries uilianries left a comment

I loved this feature! hahaha 😈

@memsharded memsharded merged commit 306c89a into conan-io:develop Jan 15, 2020
2 checks passed
@jgsogo jgsogo deleted the py2/warning branch Jan 15, 2020
@gocarlos
Copy link

@gocarlos gocarlos commented Feb 5, 2020

Changelog: Feature: Force the user to read that Python 2 has been deprecated.
Docs: conan-io/docs#1523

closes #6170

image

oficially => officially

@jgsogo
Copy link
Member Author

@jgsogo jgsogo commented Feb 5, 2020

Thanks @gocarlos!

I've opened a new release 1.22.1 fixing this typo (#6473), but we will wait sometime before releasing a minor just in case something else appears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants