Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra .props file in MSBuild helper #6374

Merged
merged 6 commits into from Jan 27, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 16, 2020

Changelog: Feature: Allow defining an extra user-defined properties .props file in MSBuild build helper.
Docs: conan-io/docs#1533

Close #6053

#tags: slow

self.assertTrue(os.path.exists(os.path.join(build_folder, "myuser.props")))
conan_props = os.path.join(build_folder, "conan_build.props")
content = load(conan_props)
self.assertIn("<RuntimeLibrary>MultiThreadedDLL</RuntimeLibrary>", content)
Copy link
Member

@jgsogo jgsogo Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I see that the value of the second file (myser.props) is used to compile, but I cannot see if the first file is taken into account, can we add some value to the conan_build.props and see that values in this file (not overridden by the user one) are also taken into account? Adding and checking something to definitions would be enough.

jgsogo
jgsogo approved these changes Jan 27, 2020
Copy link
Member

@jgsogo jgsogo left a comment

👍 Write the docs

@memsharded memsharded merged commit 56b4a69 into conan-io:develop Jan 27, 2020
2 checks passed
@jgsogo
Copy link
Member

@jgsogo jgsogo commented Jan 27, 2020

🚨 I'm pretty sure that one is not the link to the docs... cc/ @memsharded

@memsharded memsharded deleted the feature/extra_props_file branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants