extra .props file in MSBuild helper #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
jgsogo
requested changes
Jan 17, 2020
| self.assertTrue(os.path.exists(os.path.join(build_folder, "myuser.props"))) | ||
| conan_props = os.path.join(build_folder, "conan_build.props") | ||
| content = load(conan_props) | ||
| self.assertIn("<RuntimeLibrary>MultiThreadedDLL</RuntimeLibrary>", content) |
There was a problem hiding this comment.
Here I see that the value of the second file (myser.props) is used to compile, but I cannot see if the first file is taken into account, can we add some value to the conan_build.props and see that values in this file (not overridden by the user one) are also taken into account? Adding and checking something to definitions would be enough.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changelog: Feature: Allow defining an extra user-defined properties .props file in
MSBuildbuild helper.Docs: conan-io/docs#1533
Close #6053
#tags: slow