Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less verbose cmake_find_package #6389

Merged
merged 4 commits into from Mar 30, 2020

Conversation

Ignition
Copy link
Contributor

@Ignition Ignition commented Jan 20, 2020

Changelog: Fix: cmake_find_package no longer seeks to find packages which are already found.
Docs: Omit

find_package would repeat messages for common packages within the dependencies DAG. This commit skips the dependency find_package if the package was already found.

find_package would repeat messages for common packages within the
dependencies DAG. This commit skips the dependency find_package if the
package was already found.
Copy link
Member

@memsharded memsharded left a comment

This seems valid. A few things will be missing:

  • Check if the "skip" condition could be applied at an upper scope. What is the common practice for find_package() cmake scripts out there? Do they typically implement this kind of guard?
  • Some test
  • Check if needs to be added too to cmake_find_package_multi

I am assigning this to next Conan 1.24. Thanks for contributing!

@memsharded memsharded added this to the 1.24 milestone Mar 10, 2020
@czoido
Copy link
Contributor

@czoido czoido commented Mar 23, 2020

Hi @Ignition,
I have added a test for the feature as an example and solved the conflicts. We would like to merge this for 1.24 that's going to be released at the end of the March.
Could you please check the comments above?
Thanks a lot.

jgsogo
jgsogo approved these changes Mar 27, 2020
Copy link
Member

@jgsogo jgsogo left a comment

I've tested this branch with the following graph:

image


The output with the develop branch is:

⇒  cmake .. -DCMAKE_MODULE_PATH=$(pwd)
-- Conan: Using autogenerated FindlibB.cmake
-- Library hello found /Users/jgsogo/.conan/data/libB/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libB/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Conan: Using autogenerated FindlibA.cmake
-- Library hello found /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Conan: Using autogenerated FindlibC.cmake
-- Library hello found /Users/jgsogo/.conan/data/libC/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libC/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Conan: Using autogenerated FindlibA.cmake
-- Library hello found /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Skipping already existing target: CONAN_LIB::libA_hello
-- Found: /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Conan: Using autogenerated FindlibD.cmake
-- Library hello found /Users/jgsogo/.conan/data/libD/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libD/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Conan: Using autogenerated FindlibA.cmake
-- Library hello found /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Skipping already existing target: CONAN_LIB::libA_hello
-- Found: /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Conan: Using autogenerated FindlibE.cmake
-- Library hello found /Users/jgsogo/.conan/data/libE/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libE/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Conan: Using autogenerated FindlibA.cmake
-- Library hello found /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Skipping already existing target: CONAN_LIB::libA_hello
-- Found: /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Conan: Using autogenerated FindlibF.cmake
-- Library hello found /Users/jgsogo/.conan/data/libF/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libF/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Conan: Using autogenerated FindlibA.cmake
-- Library hello found /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Skipping already existing target: CONAN_LIB::libA_hello
-- Found: /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/jgsogo/dev/conan/tmp/cmakefind/_build

Notice the libA being found several times:

-- Conan: Using autogenerated FindlibA.cmake
-- Library hello found /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Skipping already existing target: CONAN_LIB::libA_hello
-- Found: /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a

The output with this PR is:

⇒  cmake .. -DCMAKE_MODULE_PATH=$(pwd)                  
-- Conan: Using autogenerated FindlibB.cmake
-- Library hello found /Users/jgsogo/.conan/data/libB/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libB/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Conan: Using autogenerated FindlibA.cmake
-- Library hello found /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libA/0.1/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib/libhello.a
-- Conan: Using autogenerated FindlibC.cmake
-- Library hello found /Users/jgsogo/.conan/data/libC/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libC/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Dependency libA already found
-- Conan: Using autogenerated FindlibD.cmake
-- Library hello found /Users/jgsogo/.conan/data/libD/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libD/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Dependency libA already found
-- Conan: Using autogenerated FindlibE.cmake
-- Library hello found /Users/jgsogo/.conan/data/libE/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libE/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Dependency libA already found
-- Conan: Using autogenerated FindlibF.cmake
-- Library hello found /Users/jgsogo/.conan/data/libF/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Found: /Users/jgsogo/.conan/data/libF/0.1/_/_/package/9d49c9183571bee6c63f123781240c1776e1fd2d/lib/libhello.a
-- Dependency libA already found
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/jgsogo/dev/conan/tmp/cmakefind/_build

Now we are repeating only the new message:

Dependency libA already found

In a much more complex graph libA (any library after a diamond) will be searched and found a lot of times. This PR is not only about noise in the output, but it is probably about performance too.

I'm not sure if the if/else should be in the consumer or at the top of the FindXXX.cmake file. No strong opinion about this.

@jgsogo jgsogo removed their assignment Mar 27, 2020
Copy link
Member

@memsharded memsharded left a comment

Hi @Ignition

I have been reviewing and testing this PR.
I have found that CMake is actually smart enough to not run again when a find.cmake or config.cmake module is used more than once. So the proposed PR actually adds more output "Dependency already found".

Could you please check this again? Is there anything I am missing.
As we want to release 1.24 tomorrow, I am going to move this to 1.25. Thanks!

@memsharded memsharded removed this from the 1.24 milestone Mar 29, 2020
@memsharded memsharded added this to the 1.25 milestone Mar 29, 2020
@jgsogo
Copy link
Member

@jgsogo jgsogo commented Mar 30, 2020

Tested this with poco and boost. The only repeated package there is zlib:

image

And the lines corresponding to zlib appear several times too:

-- Conan: Using autogenerated FindZLIB.cmake
-- Library z found /Users/jgsogo/.conan/data/zlib/1.2.11/_/_/package/f74366f76f700cc6e991285892ad7a23c30e6d47/lib/libz.a
-- Skipping already existing target: CONAN_LIB::ZLIB_z
-- Found: /Users/jgsogo/.conan/data/zlib/1.2.11/_/_/package/f74366f76f700cc6e991285892ad7a23c30e6d47/lib/libz.a

Full log:

-- Conan: Using autogenerated FindBoost.cmake
-- Library boost_wave found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_wave.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_wave.a
-- Library boost_container found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_container.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_container.a
-- Library boost_contract found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_contract.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_contract.a
-- Library boost_exception found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_exception.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_exception.a
-- Library boost_graph found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_graph.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_graph.a
-- Library boost_iostreams found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_iostreams.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_iostreams.a
-- Library boost_locale found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_locale.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_locale.a
-- Library boost_log found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_log.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_log.a
-- Library boost_program_options found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_program_options.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_program_options.a
-- Library boost_random found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_random.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_random.a
-- Library boost_regex found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_regex.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_regex.a
-- Library boost_serialization found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_serialization.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_serialization.a
-- Library boost_wserialization found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_wserialization.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_wserialization.a
-- Library boost_coroutine found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_coroutine.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_coroutine.a
-- Library boost_context found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_context.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_context.a
-- Library boost_timer found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_timer.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_timer.a
-- Library boost_thread found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_thread.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_thread.a
-- Library boost_chrono found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_chrono.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_chrono.a
-- Library boost_date_time found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_date_time.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_date_time.a
-- Library boost_atomic found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_atomic.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_atomic.a
-- Library boost_filesystem found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_filesystem.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_filesystem.a
-- Library boost_system found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_system.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_system.a
-- Library boost_type_erasure found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_type_erasure.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_type_erasure.a
-- Library boost_log_setup found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_log_setup.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_log_setup.a
-- Library boost_math_c99 found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_c99.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_c99.a
-- Library boost_math_c99f found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_c99f.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_c99f.a
-- Library boost_math_c99l found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_c99l.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_c99l.a
-- Library boost_math_tr1 found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_tr1.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_tr1.a
-- Library boost_math_tr1f found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_tr1f.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_tr1f.a
-- Library boost_math_tr1l found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_tr1l.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_math_tr1l.a
-- Library boost_stacktrace_addr2line found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_stacktrace_addr2line.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_stacktrace_addr2line.a
-- Library boost_stacktrace_basic found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_stacktrace_basic.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_stacktrace_basic.a
-- Library boost_stacktrace_noop found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_stacktrace_noop.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_stacktrace_noop.a
-- Library boost_unit_test_framework found /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_unit_test_framework.a
-- Found: /Users/jgsogo/.conan/data/boost/1.72.0/_/_/package/69168f775732984eb37d785004b6ef25111fe5f9/lib/libboost_unit_test_framework.a
-- Conan: Using autogenerated FindZLIB.cmake
-- Library z found /Users/jgsogo/.conan/data/zlib/1.2.11/_/_/package/f74366f76f700cc6e991285892ad7a23c30e6d47/lib/libz.a
-- Found: /Users/jgsogo/.conan/data/zlib/1.2.11/_/_/package/f74366f76f700cc6e991285892ad7a23c30e6d47/lib/libz.a
-- Conan: Using autogenerated FindBZip2.cmake
-- Library bz2 found /Users/jgsogo/.conan/data/bzip2/1.0.8/_/_/package/32bef4803d4b079e983ecb27f105881e778bc5a7/lib/libbz2.a
-- Found: /Users/jgsogo/.conan/data/bzip2/1.0.8/_/_/package/32bef4803d4b079e983ecb27f105881e778bc5a7/lib/libbz2.a
-- Conan: Using autogenerated FindPoco.cmake
-- Library PocoMongoDB found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoMongoDB.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoMongoDB.a
-- Library PocoNetSSL found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoNetSSL.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoNetSSL.a
-- Library PocoNet found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoNet.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoNet.a
-- Library PocoCrypto found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoCrypto.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoCrypto.a
-- Library PocoDataSQLite found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoDataSQLite.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoDataSQLite.a
-- Library PocoData found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoData.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoData.a
-- Library PocoZip found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoZip.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoZip.a
-- Library PocoUtil found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoUtil.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoUtil.a
-- Library PocoXML found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoXML.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoXML.a
-- Library PocoJSON found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoJSON.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoJSON.a
-- Library PocoRedis found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoRedis.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoRedis.a
-- Library PocoFoundation found /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoFoundation.a
-- Found: /Users/jgsogo/.conan/data/poco/1.10.1/_/_/package/8150a577f628df026b4ed5cf8cb5abcf1f60ca9b/lib/libPocoFoundation.a
-- Conan: Using autogenerated FindOpenSSL.cmake
-- Library ssl found /Users/jgsogo/.conan/data/openssl/1.0.2t/_/_/package/eb50d18a5a5d59bd0c332464a4c348ab65e353bf/lib/libssl.a
-- Found: /Users/jgsogo/.conan/data/openssl/1.0.2t/_/_/package/eb50d18a5a5d59bd0c332464a4c348ab65e353bf/lib/libssl.a
-- Library crypto found /Users/jgsogo/.conan/data/openssl/1.0.2t/_/_/package/eb50d18a5a5d59bd0c332464a4c348ab65e353bf/lib/libcrypto.a
-- Found: /Users/jgsogo/.conan/data/openssl/1.0.2t/_/_/package/eb50d18a5a5d59bd0c332464a4c348ab65e353bf/lib/libcrypto.a
-- Conan: Using autogenerated FindZLIB.cmake
-- Library z found /Users/jgsogo/.conan/data/zlib/1.2.11/_/_/package/f74366f76f700cc6e991285892ad7a23c30e6d47/lib/libz.a
-- Skipping already existing target: CONAN_LIB::ZLIB_z
-- Found: /Users/jgsogo/.conan/data/zlib/1.2.11/_/_/package/f74366f76f700cc6e991285892ad7a23c30e6d47/lib/libz.a

czoido
czoido approved these changes Mar 30, 2020
@memsharded memsharded removed this from the 1.25 milestone Mar 30, 2020
@memsharded memsharded added this to the 1.24 milestone Mar 30, 2020
@memsharded memsharded merged commit 70c7e1b into conan-io:develop Mar 30, 2020
2 checks passed
@memsharded
Copy link
Member

@memsharded memsharded commented Mar 30, 2020

Ok, lets put it into Conan 1.24. Thanks!

@Ignition
Copy link
Contributor Author

@Ignition Ignition commented Apr 4, 2020

Sorry for not responding till now, been on holiday (not working/looking at email). Thanks for continuing to improve this PR and merging.

@czoido czoido removed their assignment Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants