Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GLOBAL from targets to avoid conflict when using add_subdirectory #6488

Merged

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Feb 7, 2020

Changelog: Fix: remove GLOBAL from targets to avoid conflicts when using add_subdirectory.
Docs: conan-io/docs#1551

Fixes: #6480

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

danimtb
danimtb approved these changes Feb 7, 2020
@jgsogo jgsogo added this to the 1.22.1 milestone Feb 7, 2020
@memsharded memsharded merged commit 2782e27 into conan-io:release/1.22.1 Feb 7, 2020
2 checks passed
@jgsogo
Copy link
Member

@jgsogo jgsogo commented Feb 7, 2020

Reverts this PR #6438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants