Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing system_libs in Premake generator #6495

Merged
merged 6 commits into from Feb 8, 2020
Merged

fix missing system_libs in Premake generator #6495

merged 6 commits into from Feb 8, 2020

Conversation

Enhex
Copy link
Contributor

@Enhex Enhex commented Feb 8, 2020

Changelog: BugFix: Add system_libs to premake generator.
Docs: Omit

Fix #6494

@Enhex Enhex requested a review from SSE4 Feb 8, 2020
Copy link
Member

@memsharded memsharded left a comment

Hi @Enhex

Thanks for contributing this!

As you can see, there is a broken test, that test checks the output of the generator. Could you please fix the test too?

We are preparing a patch release/1.22.1, if you are able to do this change soon, consider applying it to that branch, as it is a bug, it could be released earlier.

SSE4
SSE4 approved these changes Feb 8, 2020
@memsharded memsharded changed the base branch from develop to release/1.22.1 Feb 8, 2020
@memsharded memsharded added this to the 1.22.1 milestone Feb 8, 2020
@memsharded memsharded merged commit b8fde5a into conan-io:release/1.22.1 Feb 8, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants