Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoiding concurrent modification of package metadata #6524

Merged
merged 2 commits into from Feb 12, 2020

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Feb 11, 2020

Changelog: Bugfix: Fixing locking system for metadata file so it can be accessed concurrently.
Docs: omit

Fixes: #6521

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

#TAGS: slow
#REVISIONS: 1

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@czoido czoido added this to the 1.21.3 milestone Feb 11, 2020
@czoido czoido removed this from the 1.21.3 milestone Feb 11, 2020
@czoido czoido added this to the 1.22.2 milestone Feb 11, 2020
@czoido czoido removed this from the 1.22.2 milestone Feb 11, 2020
@czoido czoido added this to the 1.22.2 milestone Feb 11, 2020
@memsharded memsharded requested a review from jgsogo Feb 12, 2020
jgsogo
jgsogo approved these changes Feb 12, 2020
Copy link
Member

@jgsogo jgsogo left a comment

👍

but, please, open an issue to refactor the locking mechanism we are using, now we have them in the download-cache, in the package_lock, also here in the update_metadata, I think it is worth to have a context manager in conan.utils.threading that works for processes and threads (I feel like we can handle both of them always... no need to choose between processes and threads).

conans/client/cmd/uploader.py Outdated Show resolved Hide resolved
@czoido czoido merged commit ad9f974 into conan-io:release/1.22.2 Feb 12, 2020
2 checks passed
@memsharded memsharded deleted the hotfix/concurrent_upload branch Feb 12, 2020
czoido added a commit to czoido/conan that referenced this issue Feb 13, 2020
* avoiding concurrent modification of package metadata

* move checksums closer

Co-authored-by: James <james@conan.io>
czoido added a commit that referenced this issue Feb 14, 2020
* avoiding concurrent modification of package metadata

* move checksums closer

Co-authored-by: James <james@conan.io>

Co-authored-by: James <james@conan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants