Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json output serialization for cpp_info components #6966

Merged
merged 3 commits into from May 11, 2020

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented May 6, 2020

Changelog: Bugfix: Fix json output serialization for cpp_info.components.
Docs: Omit

  • Refer to the issue that supports this Pull Request: conan-io/conan-center-index#1541 (comment)
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@jgsogo jgsogo added this to the 1.25.1 milestone May 6, 2020
@czoido
Copy link
Contributor

@czoido czoido commented May 7, 2020

@danimtb please, point this to the release/1.25 branch.

@danimtb danimtb changed the base branch from develop to release/1.25 May 7, 2020
jgsogo
jgsogo approved these changes May 7, 2020
Copy link
Member

@jgsogo jgsogo left a comment

👍

First of all is to fix the bug, then we can think about documenting the JSON output. Can we document this output as it is after this PR? If the answer is yes, then I would open a PR to the docs too.

@danimtb
Copy link
Member Author

@danimtb danimtb commented May 7, 2020

@jgsogo we have the output documented here https://docs.conan.io/en/latest/reference/commands/output/install.html but it says:

cpp_info: dictionary containing the build information defined in the package_info method on the recipe.

@memsharded memsharded merged commit 7a00f7d into conan-io:release/1.25 May 11, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants