Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: expose msvs_toolset tool #7134

Merged
merged 3 commits into from Jun 3, 2020
Merged

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jun 2, 2020

closes: #7061
Changelog: Feature: Expose msvs_toolset tool.
Docs: conan-io/docs#1715

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: SSE4 <tomskside@gmail.com>
if isinstance(conanfile, ConanFile):
settings = conanfile.settings
else:
settings = conanfile
Copy link
Contributor

@jgsogo jgsogo Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@memsharded memsharded Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this will not be broken with this, right?

@SSE4 SSE4 closed this Jun 3, 2020
@SSE4 SSE4 reopened this Jun 3, 2020
@jgsogo jgsogo added this to the 1.26 milestone Jun 3, 2020
jgsogo
jgsogo approved these changes Jun 3, 2020
if isinstance(conanfile, ConanFile):
settings = conanfile.settings
else:
settings = conanfile
Copy link
Member

@memsharded memsharded Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this will not be broken with this, right?

@memsharded memsharded assigned jgsogo and unassigned memsharded Jun 3, 2020
@memsharded memsharded merged commit 0923fc3 into conan-io:develop Jun 3, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] expose msvc_toolset
3 participants