Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Failure building a repeated build require in a lockfile #7144

Closed
wants to merge 5 commits into from

Conversation

jgsogo
Copy link
Member

@jgsogo jgsogo commented Jun 3, 2020

Changelog: Fix: Build first ocurrence of a node in a lockfile when it is repeated (build requires)
Docs: omit

closes #7137
closes #7141
closes #6065

@jgsogo jgsogo added this to the 1.27 milestone Jun 8, 2020
@memsharded memsharded self-assigned this Jun 10, 2020
@memsharded
Copy link
Member

memsharded commented Jun 10, 2020

@jgsogo I have removed the check for multiple matches, and picking just the first one, seems to work fine. A future step would be to specify the node you want by node-id, not package reference, but I think that will make the UI more complicated and difficult to understand, this should be ok for practically all cases. Please review.

@jgsogo jgsogo marked this pull request as ready for review Jun 24, 2020
Copy link
Member Author

@jgsogo jgsogo left a comment

👍

@jgsogo jgsogo requested a review from czoido Jun 24, 2020
@memsharded memsharded modified the milestones: 1.27, 1.28 Jun 29, 2020
@memsharded
Copy link
Member

memsharded commented Jul 15, 2020

This is included and is superseded in #7243, I think this can be closed now.

@memsharded memsharded closed this Jul 15, 2020
@jgsogo jgsogo deleted the test/lockfile_brs branch Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment