Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [xbuild] build_requires from host profile is applied to other build requires #7169

Merged
merged 8 commits into from Jun 23, 2020

Conversation

jgsogo
Copy link
Member

@jgsogo jgsogo commented Jun 9, 2020

Changelog: Fix: Packages listed as build_requires in recipes that belong to the host context don't add as build_requires those listed in the host profile.
Docs: omit

The BR that is declared in the profile_host is incorrectly applied to the other build_requires that is declared in the library recipe.

closes #7214

@jgsogo jgsogo added this to the 1.26.1 milestone Jun 9, 2020
@jgsogo jgsogo changed the base branch from develop to release/1.26 Jun 9, 2020
@danimtb danimtb requested a review from memsharded Jun 19, 2020
Copy link
Member Author

@jgsogo jgsogo left a comment

(I cannot request changes as it is my PR... )

@@ -52,6 +52,5 @@ def test_br_from_profile_host_and_profile_build(self):
t.run("create library.py --profile:host=profile_host --profile:build=profile_build --build *")
self.assertNotIn("br1/version: Applying build-requirement: br2/version", t.out)
self.assertIn("br1/version: Applying build-requirement: br3/version", t.out)
self.assertIn("br2/version: Applying build-requirement: br3/version", t.out)
Copy link
Member Author

@jgsogo jgsogo Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course this one fails, but we need to write down if this is a known bug we don't want to fix right now or it is a design decision not to apply BRs to BRs when they are defined in profiles.

@memsharded memsharded merged commit d3269c4 into conan-io:release/1.26 Jun 23, 2020
2 checks passed
@jgsogo jgsogo deleted the bug/xbuild branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants