[bug] [xbuild] build_requires from host profile is applied to other build requires #7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgsogo
reviewed
Jun 19, 2020
conans/test/functional/cross_building/build_requires_from_profile_test.py
Show resolved
Hide resolved
…ile_test.py Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
jgsogo
reviewed
Jun 23, 2020
| @@ -52,6 +52,5 @@ def test_br_from_profile_host_and_profile_build(self): | |||
| t.run("create library.py --profile:host=profile_host --profile:build=profile_build --build *") | |||
| self.assertNotIn("br1/version: Applying build-requirement: br2/version", t.out) | |||
| self.assertIn("br1/version: Applying build-requirement: br3/version", t.out) | |||
| self.assertIn("br2/version: Applying build-requirement: br3/version", t.out) | |||
There was a problem hiding this comment.
Of course this one fails, but we need to write down if this is a known bug we don't want to fix right now or it is a design decision not to apply BRs to BRs when they are defined in profiles.
memsharded
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changelog: Fix: Packages listed as
build_requiresin recipes that belong to the host context don't add asbuild_requiresthose listed in the host profile.Docs: omit
The BR that is declared in the
profile_hostis incorrectly applied to the other build_requires that is declared in thelibraryrecipe.closes #7214