allow no user/channel match in --build #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgsogo
approved these changes
Jun 22, 2020
jgsogo
requested changes
Jun 22, 2020
conans/client/graph/build_mode.py
Outdated
| is_matching_name = fnmatch.fnmatchcase(ref.name, pattern) | ||
| is_matching_ref = fnmatch.fnmatchcase(repr(ref.copy_clear_rev()), pattern) | ||
| # Remove the @ at the end, to match for "conan install pkg/0.1@ --build=pkg/0.1@" | ||
| clean_pattern = pattern[:-1] if pattern.endswith("@") else pattern |
There was a problem hiding this comment.
Better to clean the patterns when they are added to the self.patterns list
There was a problem hiding this comment.
Done. I have also added the possibility to match a complete reference including RREV, with and without user/channel
jgsogo
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changelog: Fix: Allow
--build=Pkg/0.1@to match thePkg/0.1package, so theconan install Pkg/0.1@ --build=Pkg/0.1@also works.Docs: Omit
Note:
conan install Pkg/0.1@user/channel --build=Pkg/0.1@user/channelworksThis would be a nice addition so the
conan graph build-orderoutput can be more directly used to build packages without user/channel.#tags: slow