Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow no user/channel match in --build #7219

Merged
merged 5 commits into from Jun 24, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 19, 2020

Changelog: Fix: Allow --build=Pkg/0.1@ to match the Pkg/0.1 package, so the conan install Pkg/0.1@ --build=Pkg/0.1@ also works.
Docs: Omit

Note: conan install Pkg/0.1@user/channel --build=Pkg/0.1@user/channel works

This would be a nice addition so the conan graph build-order output can be more directly used to build packages without user/channel.

#tags: slow

@memsharded memsharded added this to the 1.27 milestone Jun 19, 2020
jgsogo
jgsogo approved these changes Jun 22, 2020
is_matching_name = fnmatch.fnmatchcase(ref.name, pattern)
is_matching_ref = fnmatch.fnmatchcase(repr(ref.copy_clear_rev()), pattern)
# Remove the @ at the end, to match for "conan install pkg/0.1@ --build=pkg/0.1@"
clean_pattern = pattern[:-1] if pattern.endswith("@") else pattern
Copy link
Member

@jgsogo jgsogo Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to clean the patterns when they are added to the self.patterns list

Copy link
Member Author

@memsharded memsharded Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I have also added the possibility to match a complete reference including RREV, with and without user/channel

@memsharded memsharded requested a review from jgsogo Jun 23, 2020
jgsogo
jgsogo approved these changes Jun 24, 2020
@jgsogo jgsogo merged commit 3a6aad0 into conan-io:develop Jun 24, 2020
2 checks passed
@memsharded memsharded deleted the feature/build_mode_match branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants