Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xbuild] Provide "user_info" from every context #7266

Merged
merged 5 commits into from Jun 30, 2020

Conversation

jgsogo
Copy link
Member

@jgsogo jgsogo commented Jun 29, 2020

Changelog: Feature: (Only if using two profiles) Information from the self.user_info field is provided to consumers: information from the host context is accessible via deps_user_info attribute, and information from the build context via user_info_build attribute.
Docs: conan-io/docs#1753

Closes #7247

Q: Using a new approach with two profiles, do we want both variables deps_user_info and user_info_host for the information coming from host context?
==> Do not add user_info_host until we know what to do with deps_cpp_info, all information from host should have the same access pattern.

@jgsogo jgsogo changed the title Provide "user_info" from every context [xbuild] Provide "user_info" from every context Jun 29, 2020
Copy link
Member

@memsharded memsharded left a comment

Please check broken test in py27

@jgsogo jgsogo added this to the 1.27 milestone Jun 29, 2020
@jgsogo jgsogo requested a review from czoido Jun 29, 2020
@jgsogo jgsogo self-assigned this Jun 29, 2020
czoido
czoido approved these changes Jun 30, 2020
@jgsogo
Copy link
Member Author

@jgsogo jgsogo commented Jun 30, 2020

Removed user_info_host and added some docs.

@jgsogo jgsogo requested a review from czoido Jun 30, 2020
czoido
czoido approved these changes Jun 30, 2020
@memsharded memsharded merged commit a312aef into conan-io:develop Jun 30, 2020
2 checks passed
@jgsogo jgsogo deleted the feature/user_info_context branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants