Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conan_v2_mode] Fail if build_type or compiler is not defined for build helpers #7327

Merged
merged 4 commits into from Jul 9, 2020

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Jul 7, 2020

Changelog: Feature: When using CONAN_V2_MODE if build_type or compiler are not defined Conan will raise an error.
Docs: conan-io/docs#1783

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

self._build_type = self._ss("build_type")
if not self._build_type:
Copy link
Member

@memsharded memsharded Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are setters for build_type, you don't want to raise here, but to delay the check to the configure() step

@memsharded memsharded added this to the 1.28 milestone Jul 9, 2020
jgsogo
jgsogo approved these changes Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants