Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_config generator: do not modify value in the shared 'cpp_info' object #7482

Merged
merged 5 commits into from Aug 5, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Aug 3, 2020

Changelog: Fix: Do not override value of public_deps in pkg_config generator.
Docs: omit

close #7474

The issue happens only when the cmake/cmake_find_pakcage generator is generated after pkg_config one. The order of generators is not always the same (not reproducible).

Support for components in pkg_config generator was introduced here: #7413

@jgsogo jgsogo added this to the 1.28.1 milestone Aug 3, 2020
@jgsogo jgsogo requested a review from czoido Aug 3, 2020
czoido
czoido approved these changes Aug 4, 2020
@memsharded memsharded merged commit 22df79b into conan-io:release/1.28 Aug 5, 2020
2 checks passed
@jgsogo jgsogo deleted the fix/7474-components branch Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants