Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7503 Extend iOS versions #7507

Merged
merged 5 commits into from Aug 25, 2020

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Aug 5, 2020

Add new iOS 13 minor version in default settings.yml

Changelog: Feature: Support from iOS 13.2 to 13.6.
Docs: conan-io/docs#1800
closes #7503

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@jgsogo jgsogo added this to the 1.29 milestone Aug 6, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries closed this Aug 10, 2020
@uilianries
Copy link
Member Author

uilianries commented Aug 10, 2020

Network error, not related to this PR. Restarting ...

@uilianries uilianries reopened this Aug 10, 2020
Copy link
Member

@jgsogo jgsogo left a comment

@uilianries You cannot modify the settings from an older version, you need to add at the bottom of conans/client/migrations_settings.py a new entry with the settings for 1.29.0:

settings_1_29_0 = """...."""

@uilianries
Copy link
Member Author

uilianries commented Aug 14, 2020

🤦

uilianries added 3 commits Aug 14, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

uilianries commented Aug 14, 2020

@jgsogo Can we use template/jinja2 to avoid all this ugly copy/paste?

jgsogo
jgsogo approved these changes Aug 15, 2020
@jgsogo
Copy link
Member

jgsogo commented Aug 15, 2020

We need to figure out something, at least now we have some tests so we don't forget about the new settings. I would prefer to save diffs (like Git, like database migrations,...) over a template, because we need to be able to reconstruct the settings as they were when we released the corresponding version.

@memsharded memsharded merged commit 2324c4a into conan-io:develop Aug 25, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend iOS version in settings.yml
3 participants