Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include prerrelease versions when resolving required_conan_version #7535


Copy link

@czoido czoido commented Aug 10, 2020

Changelog: Fix: Add pre-release versions when resolving required_conan_version.
Docs: omit

When resolving required_conan_version, Conan did not take into account the prerelease versions, so for example 1.29.0-dev was not being resolved as >=1.28.0 so this was failing.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@czoido czoido added this to the 1.29 milestone Aug 10, 2020
@memsharded memsharded mentioned this pull request Aug 10, 2020
5 tasks
@czoido czoido requested a review from jgsogo August 11, 2020 07:28
jgsogo approved these changes Aug 11, 2020
@memsharded memsharded merged commit 8efd0fa into conan-io:develop Aug 11, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants