Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frogarian display in gnome-terminal (TERM=xterm-256color) #7553

Merged
merged 1 commit into from Aug 25, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Aug 14, 2020

Changelog: Bugfix: Make frogarian show up as a whole (not sliced) on linux terminal.
Docs: Omit

The frogarian command showed only a sliced-up frogarian.
I removed the save and restore position codes at the end and beginning of lines.

/cc @danimtb because you added the command

@memsharded
Copy link
Member

memsharded commented Aug 19, 2020

Looks good, but someone please check this works also on Windows and OSX terminals too.
Thanks!

@memsharded memsharded added this to the 1.29 milestone Aug 19, 2020
@uilianries
Copy link
Member

uilianries commented Aug 19, 2020

Working on Windows 10 with classic cmd and cmder:

Untitled

@uilianries
Copy link
Member

uilianries commented Aug 19, 2020

@jgsogo Could you please check on OSX?

@memsharded memsharded merged commit 1f89d80 into conan-io:develop Aug 25, 2020
2 checks passed
@madebr madebr deleted the frogarian branch Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants