Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix frameworks usage with components (cmake_find_package_multi) #7580

Merged
merged 1 commit into from Aug 26, 2020

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Aug 23, 2020

closes: #7549

Changelog: Bugfix: Fix frameworks usage with components for cmake_find_package_multi generator.
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@jgsogo jgsogo added this to the 1.29 milestone Aug 24, 2020
topics = ("conan",)
url = "https://github.com/conan-io/conan-center-index"
homepage = "https://www.example.com"
license = "MIT"
Copy link
Member

@memsharded memsharded Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many unneeded things, this could be much shorter.

@@ -456,3 +456,135 @@ def test(self):
# Check we are using the framework
link_txt = t.load(os.path.join('CMakeFiles', 'test_package.dir', 'link.txt'))
self.assertIn("-framework Foundation", link_txt)

def component_test(self):
conanfile_py = textwrap.dedent("""
Copy link
Member

@memsharded memsharded Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

textwrap.dedent useless if you don't indent

@memsharded memsharded merged commit 194cdc1 into conan-io:develop Aug 26, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] cmake_find_package_multi: frameworks not propagated on MacOS
3 participants