Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/markdown cmake gen info #7690

Merged

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Sep 9, 2020

Changelog: Feature: List cpp_info.names and cpp_info.filenames in JSON and Markdown generator.
Docs: conan-io/docs#1844

Closes #7525

Now anyone can read easily what will be produced when mixing cpp_info.name + cpp_info.names + cpp_info.filenames. The current feature works good and solves the cmake targets, but is almost unreadable when you don't know the feature in details. I hope these generators can show the final result without much knowledgement about the feature.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

uilianries added 2 commits Sep 9, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Copy link
Member

@memsharded memsharded left a comment

Looking good, thanks

@memsharded memsharded added this to the 1.30 milestone Sep 9, 2020
uilianries added 2 commits Sep 18, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded memsharded merged commit 436450e into conan-io:develop Sep 21, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] CLI command to discover the cmake_find_package filename from the Conan package name?
3 participants