Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7694, translate settings.os value 'Macos' to 'Darwin' for CMAKE_… #7695

Conversation

Erlkoenig90
Copy link
Contributor

@Erlkoenig90 Erlkoenig90 commented Sep 10, 2020

Changelog: Bugfix: Translate settings.os value Macos to Darwin for CMAKE_SYSTEM_NAME to allow compiling CMake-based packages for MacOS.
Docs: omit

Fixes #7694

…SYSTEM_NAME to allow compiling CMake-based packages for Mac OS

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

…r CMAKE_SYSTEM_NAME to allow compiling CMake-based packages for Mac OS
@CLAassistant
Copy link

CLAassistant commented Sep 10, 2020

CLA assistant check
All committers have signed the CLA.

SSE4
SSE4 approved these changes Sep 11, 2020
@memsharded memsharded added this to the 1.30 milestone Sep 25, 2020
@memsharded memsharded merged commit 2becd7f into conan-io:develop Sep 25, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] CMAKE_SYSTEM_NAME is set to Macos instead of Darwin when settings.os = Macos
4 participants