Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing back build colourisation #7740

Merged
merged 8 commits into from Sep 23, 2020
Merged

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Sep 22, 2020

Changelog: Fix: Do not capture output for normal conan run (no logging or testing) when launching processes via ConanRunner so that color from build tools output is not lost.
Docs: omit

This is a proposal for recovering ConanRunner colorisation. Maybe we just want to capture the stdout using Popen and therefore disabling color codes when we are running the tests (the stream will be a StringIO) or when we explicitly set run_to_file=True or run_to_output=False.

Closes: #5597

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@czoido czoido closed this Sep 22, 2020
@czoido czoido reopened this Sep 22, 2020
@czoido czoido closed this Sep 22, 2020
@czoido czoido reopened this Sep 22, 2020
@czoido czoido closed this Sep 23, 2020
@czoido czoido reopened this Sep 23, 2020
@czoido czoido marked this pull request as ready for review Sep 23, 2020
@czoido czoido added this to the 1.30 milestone Sep 23, 2020
@czoido czoido requested a review from memsharded Sep 23, 2020
@memsharded memsharded merged commit 558a2ce into conan-io:develop Sep 23, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolchain Build Colourisation Lost
2 participants