Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix intel functions with intel_ because they are now exposed via tools #7821

Merged

Conversation

solvingj
Copy link
Contributor

@solvingj solvingj commented Oct 5, 2020

Changelog: Fix: prefix intel functions with intel_ because they are now exposed via tools. Fixes #7820.
Docs: conan-io/docs#1875

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@memsharded memsharded added this to the 1.30.1 milestone Oct 6, 2020
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it is nicer to be explicit.

If we are going to break, even if experimental, better do it soon. Please target the release/1.30 branch and we will release it in 1.30.1

@solvingj solvingj changed the base branch from develop to release/1.30 Oct 6, 2020
@jgsogo
Copy link
Contributor

jgsogo commented Oct 6, 2020

🙌 with the changes, but we need to remove commits coming from develop before merging this one.

@solvingj solvingj closed this Oct 6, 2020
@solvingj solvingj force-pushed the prefix_intel_function_names branch from d4d4fa7 to 4238de0 Compare Oct 6, 2020
@solvingj solvingj deleted the prefix_intel_function_names branch Oct 6, 2020
@solvingj solvingj restored the prefix_intel_function_names branch Oct 6, 2020
@solvingj
Copy link
Contributor Author

solvingj commented Oct 6, 2020

please re-open

@solvingj solvingj reopened this Oct 6, 2020
jgsogo
jgsogo approved these changes Oct 6, 2020
@jgsogo jgsogo assigned memsharded and unassigned solvingj Oct 6, 2020
@memsharded memsharded merged commit 9e244a7 into conan-io:release/1.30 Oct 6, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] intel functions exposed under tools without prefix
3 participants