Feature/package revision in json info #7890
Conversation
| @@ -177,8 +179,8 @@ def _add_if_exists(attrib, as_list=False): | |||
| if isinstance(ref, ConanFileReference): | |||
| item_data["recipe"] = node.recipe | |||
|
|
|||
| if get_env("CONAN_CLIENT_REVISIONS_ENABLED", False) and node.ref.revision: | |||
There was a problem hiding this comment.
I am reviewing this, seems unused now.
| @@ -106,6 +106,7 @@ def _print(it_field, show_field=None, name=None, color=Color.BRIGHT_GREEN): | |||
| _print("recipe", name="Recipe", color=None) | |||
| if show_revisions: | |||
| _print("revision", name="Revision", color=None) | |||
| _print("package_revision", name="Package revision", color=None) | |||
There was a problem hiding this comment.
Printing the package revision to screen too
There was a problem hiding this comment.
For the assertNotIn I did is the test not worth it ?
There was a problem hiding this comment.
The problem is that it was asserting that the revisions are not defined, the opposite of what we want. We want the revisions to be part of the information. That test now checks for self.assertEqual() to check that it is both there and has a value, instead of checking that it is not defined.
There was a problem hiding this comment.
Hi @sdmg15
I think this is ready for another review, and we can take it out of draft. Assigning it tentatively for next Conan 1.31 release
Changelog: Feature: Including package revision information in output from
conan info(when revisions are enabled).Docs: Omit
closes [feature] 'conan info' to return the package revision #7796
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.