Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'provides' and 'deprecated' fields to 'conan info' output #7916

Merged
merged 4 commits into from Oct 21, 2020
Merged

Add 'provides' and 'deprecated' fields to 'conan info' output #7916

merged 4 commits into from Oct 21, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Oct 20, 2020 •
edited

Changelog: Feature: Add provides and deprecated fields to conan info output
Docs: omit

Changes:

  • Add provides and deprecated fields to conan info output
  • Minor format changes:
    • test names to match standard names expected by pytest
    • some textwrap.dedent

jgsogo
jgsogo commented Oct 20, 2020
View reviewed changes
conans/client/conan_command_output.py
@@ -166,15 +167,16 @@ def _add_if_exists(attrib, as_list=False):
if not as_list:
item_data[attrib] = value
else:
item_data[attrib] = list(value) if isinstance(value, (list, tuple, set)) \
else [value, ]
item_data[attrib] = make_tuple(value)
Copy link
Contributor Author

@jgsogo jgsogo Oct 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing current output: from list to tuple, breaking?

TBH, I don't think so, this information is consumed in two different ways: JSON and written on the screen. For JSON it is the same a list and a tuple, in the screen we are writing a , -separated list. Am I missing other scenarios?

@jgsogo jgsogo requested a review from danimtb October 21, 2020 11:34
@jgsogo jgsogo marked this pull request as ready for review October 21, 2020 11:35
@memsharded memsharded added this to the 1.31 milestone Oct 21, 2020
@memsharded memsharded merged commit a088af5 into conan-io:develop Oct 21, 2020
2 checks passed
@jgsogo jgsogo deleted the feat/info-fields branch October 21, 2020 13:37
danimtb
danimtb reviewed Oct 21, 2020
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb left review comments

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgsogo @danimtb @memsharded