New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CMAKE_SYSTEM_NAME to iOS, tvOS, watchOS from CMake 3.14 #7924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Oct 22, 2020
a4z
approved these changes
Oct 22, 2020
jgsogo
suggested changes
Oct 22, 2020
jgsogo
suggested changes
Oct 22, 2020
jgsogo
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changelog: Fix: Set
CMAKE_SYSTEM_NAME
set toiOS
,tvOS
orwatchOS
orDarwin
depending on the CMake version.Docs: Omit
Closes: #7875
Since CMake 3.14 setting
CMAKE_SYSTEM_NAME
toiOS
,tvOS
orwatchOS
is supported. This PR checks the version of CMake in the build helper and sets the definition accordingly.TODO: Update this implementation in the toolchain files. I'll open an issue about this.
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.