Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/toolchain msbuild cmd #7941

Merged
merged 15 commits into from Oct 30, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Oct 26, 2020

Changelog: Feature: Provide a MSBuildCmd helper class that encapsulates calling MSBuild.
Docs: conan-io/docs#1907

Close #7824
Close #7606

@memsharded memsharded marked this pull request as ready for review Oct 28, 2020
@memsharded memsharded added this to the 1.31 milestone Oct 28, 2020
@@ -4,7 +4,7 @@
from conans.client.build.cmake import CMake
from conans.client.toolchain.cmake import CMakeToolchain
from conans.client.toolchain.make import MakeToolchain
from conans.client.toolchain.msbuild import MSBuildToolchain
from conans.client.toolchain.msbuild import MSBuildToolchain, MSBuildCmd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the tool is important. We could dynamically change the MSBuild helper as we do with CMake, but I am not convinced about that approach, so I am suggesting a new helper. But we can discuss.

@memsharded memsharded requested a review from jgsogo Oct 28, 2020
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, just questions for my own confirmation. I would like to know your concerns about following the same "replacement" trick as in the CMake helper.

conans/client/toolchain/msbuild.py Show resolved Hide resolved
conans/test/functional/toolchain/test_msbuild.py Outdated Show resolved Hide resolved
conans/client/toolchain/visual.py Show resolved Hide resolved
conans/client/toolchain/msbuild.py Show resolved Hide resolved
conans/client/build/msbuild.py Outdated Show resolved Hide resolved
conans/test/functional/toolchain/test_msbuild.py Outdated Show resolved Hide resolved
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
@memsharded memsharded merged commit 706e9b9 into conan-io:develop Oct 30, 2020
2 checks passed
@memsharded memsharded deleted the feature/toolchain_msbuild_cmd branch Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] MSBuild command line helper [bug] MSBuild calls devenv by default, even if not available
3 participants