Feature/toolchain msbuild cmd #7941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Oct 28, 2020
conans/__init__.py
Outdated
| @@ -4,7 +4,7 @@ | |||
| from conans.client.build.cmake import CMake | |||
| from conans.client.toolchain.cmake import CMakeToolchain | |||
| from conans.client.toolchain.make import MakeToolchain | |||
| from conans.client.toolchain.msbuild import MSBuildToolchain | |||
| from conans.client.toolchain.msbuild import MSBuildToolchain, MSBuildCmd | |||
There was a problem hiding this comment.
The name of the tool is important. We could dynamically change the MSBuild helper as we do with CMake, but I am not convinced about that approach, so I am suggesting a new helper. But we can discuss.
danimtb
approved these changes
Oct 28, 2020
jgsogo
reviewed
Oct 29, 2020
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
jgsogo
reviewed
Oct 29, 2020
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changelog: Feature: Provide a
MSBuildCmdhelper class that encapsulates calling MSBuild.Docs: conan-io/docs#1907
Close #7824
Close #7606