Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass conanfile to download_package hooks #7968

Merged

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Oct 29, 2020

Changelog: Feature: Add argument conanfile to pre_download_package and post_download_package hook functions.
Docs: conan-io/docs#1905

closes #7544

It was already documented for the post_download_hook, but it is easy to add it to the pre_xxx one.

@jgsogo jgsogo marked this pull request as ready for review Oct 29, 2020
@jgsogo jgsogo changed the title [wip] Pass conanfile to download_package hooks Pass conanfile to download_package hooks Oct 29, 2020
@jgsogo jgsogo requested a review from danimtb Oct 29, 2020
@jgsogo jgsogo added this to the 1.31 milestone Oct 29, 2020
@memsharded memsharded merged commit b256f96 into conan-io:develop Oct 29, 2020
2 checks passed
@jgsogo jgsogo deleted the feat/post_download_hook-conanfile branch Oct 29, 2020
jgsogo added a commit to jgsogo/conan that referenced this pull request Oct 30, 2020
czoido pushed a commit that referenced this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] post_download_package hook
3 participants