New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msbuild generator custom configs #8014
msbuild generator custom configs #8014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes/suggestiongs, and main comment: IMO, we should remove the config_filename
, it adds a degree of freedom that is not needed and it can be misleading because it is not considered in the condition:
def toolchain(self):
ms = MSBuildDeps(self)
ms.configuration = "My"+str(self.settings.build_type)
ms.platform = "My"+str(self.settings.arch)
ms.config_filename = 'optTrue' if self.options.opt1 else 'optFalse'
ms.generate()
We get two different files, but we cannot reach one of them, which one? It depends on the install order...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments
Changelog: Feature: Allow (experimental) custom configuration of the
msbuild
generator.Changelog: Feature: Rename
msbuild
generator toMSBuildDeps
and use the newgenerate()
method.Docs: conan-io/docs#1952
Simplified from https://github.com/conan-io/conan/pull/7754/files
This is ONLY the
msbuild
part. There are 2 external things to be addressed too, but lets discuss those in other issues:config
mechanism to propagate things from config and command line to the recipes and codebase.#tags: slow