Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ninja + visual testing #8034

Merged
merged 4 commits into from Nov 19, 2020
Merged

ninja + visual testing #8034

merged 4 commits into from Nov 19, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Nov 10, 2020 •
edited by czoido

Changelog: Feature: Preliminary experimental support for toolchains with CMake + Visual + Ninja.
Docs: Omit

CMakeToolchain with Ninja for VS doesn't work, it was using the gcc compiler.

#tags: slow

@memsharded memsharded added this to the 1.32 milestone Nov 10, 2020
@memsharded memsharded marked this pull request as ready for review November 18, 2020 12:55
@uilianries
Copy link
Member

The test shows the same description when running:

Ninja build must proceed using default profile and cmake build (Linux) ... SKIP: Not tested yet
Ninja build must proceed using default profile and cmake build (Windows) ... ok
Ninja build must proceed using default profile and cmake build (Windows) ... ok

@uilianries
Copy link
Member

LGTM, I've tested on my Windows machine and works pretty fine.

Here is the result of my tests: https://gist.github.com/uilianries/f8b7edc36b1f638e44db9d11421d1ce1

memsharded and others added 2 commits November 18, 2020 16:08
@memsharded @uilianries
Update conans/test/integration/toolchains/cmake/test_ninja.py
ca10e2b 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@memsharded @uilianries
Update conans/test/integration/toolchains/cmake/test_ninja.py
6695b69 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@memsharded memsharded merged commit 7792782 into conan-io:develop Nov 19, 2020
2 checks passed
@memsharded memsharded deleted the feature/toolchain_ninja_visual branch November 19, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@jgsogo jgsogo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @uilianries