Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for cmake_multi generator #1121

Merged
merged 7 commits into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@danimtb
Copy link
Member

commented Mar 15, 2019

Docs for issue conan-io/conan#2820 and PR conan-io/conan#4721

Built on top of #1120

⚠️ This PR should be reviewed and merged after #1120 is merged to master and develop branch is updated with its changes ⚠️

@ghost ghost assigned danimtb Mar 15, 2019

@ghost ghost added the stage: review label Mar 15, 2019

@danimtb danimtb added this to the 1.14 milestone Mar 15, 2019

@danimtb danimtb removed their assignment Mar 15, 2019

@danimtb danimtb changed the title Feature/conan/2820 Docs for cmake_multi generator Mar 15, 2019

@ghost ghost assigned danimtb Mar 15, 2019

@jgsogo
Copy link
Member

left a comment

Just a preliminar review, I'll come back once the depending PR is merged.


Macros available in *conanbuildinfo_multi.cmake*

This comment has been minimized.

Copy link
@jgsogo

jgsogo Mar 18, 2019

Member

I would focus on the differences between cmake and cmake_multi. This piece of docs is not going to be complete (above you have already referenced to "same as conanbuildinfo.cmake with suffix _DEBUG"), so I think it makes no sense to have here almost the copy/paste.

Maybe we have to document here how this file includes debug/release one, and those more generic variables and macros...

@danimtb danimtb referenced this pull request Mar 26, 2019

Merged

conan_basic_setup() same interface for cmake_multi #4721

5 of 5 tasks complete

@danimtb danimtb requested a review from jgsogo Mar 26, 2019

@danimtb danimtb removed their assignment Mar 26, 2019

@danimtb

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Please take a look at this so it can be moved forward as the code PR was already merged

@jgsogo

jgsogo approved these changes Mar 27, 2019

Copy link
Member

left a comment

Better docs, better software! 🎉

@jgsogo jgsogo merged commit 68779c7 into conan-io:develop Mar 27, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.