Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain about SystemPackageTool and sudo #1127

Merged
merged 6 commits into from Mar 20, 2019

Conversation

Projects
None yet
4 participants
@uilianries
Copy link
Member

commented Mar 19, 2019

How does SystemPackageTool use sudo when CONAN_SYSREQUIRES_SUDO is not defined?

related issue: conan-io/conan#4770
related PR: conan-io/conan#4774

uilianries added some commits Mar 19, 2019

Explain about SystemPackageTool and sudo
- How does SystemPackageTool use sudo when CONAN_SYSREQUIRES_SUDO
  is not defined.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
sudo is not 'it'
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@ghost ghost assigned uilianries Mar 19, 2019

@ghost ghost added the stage: review label Mar 19, 2019

@uilianries uilianries referenced this pull request Mar 19, 2019

Merged

#4770 Do not force sudo when it is not found #4774

5 of 5 tasks complete
Show resolved Hide resolved reference/conanfile/methods.rst Outdated
Fix sudo require condition
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@danimtb
Copy link
Member

left a comment

Looking good 👍 Only suggestions for rephrasing

Show resolved Hide resolved reference/conanfile/methods.rst Outdated
Show resolved Hide resolved reference/conanfile/methods.rst Outdated
Show resolved Hide resolved reference/conanfile/methods.rst Outdated

danimtb and others added some commits Mar 20, 2019

sudo requirements for SystemPackageTool
Co-Authored-By: uilianries <uilianries@gmail.com>
sudo is available in the PATH
Co-Authored-By: uilianries <uilianries@gmail.com>
sudo platform is posix
Co-Authored-By: uilianries <uilianries@gmail.com>
@uilianries

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

Thanks @danimtb ! Much better now!

@danimtb danimtb added this to the 1.14 milestone Mar 20, 2019

@danimtb danimtb assigned danimtb and unassigned uilianries Mar 20, 2019

@danimtb danimtb merged commit 75399fb into conan-io:develop Mar 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 20, 2019

@jakobjw

This comment has been minimized.

Copy link

commented Apr 4, 2019

Typo in docs/methods.rst: "environemtn"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.