Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain about SystemPackageTool and sudo #1127

Merged
merged 6 commits into from Mar 20, 2019

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Mar 19, 2019

How does SystemPackageTool use sudo when CONAN_SYSREQUIRES_SUDO is not defined?

related issue: conan-io/conan#4770
related PR: conan-io/conan#4774

uilianries added 2 commits Mar 19, 2019
- How does SystemPackageTool use sudo when CONAN_SYSREQUIRES_SUDO
  is not defined.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Copy link
Member

@danimtb danimtb left a comment

Looking good 👍 Only suggestions for rephrasing

reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
danimtb and others added 3 commits Mar 20, 2019
Co-Authored-By: uilianries <uilianries@gmail.com>
Co-Authored-By: uilianries <uilianries@gmail.com>
Co-Authored-By: uilianries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

@uilianries uilianries commented Mar 20, 2019

Thanks @danimtb ! Much better now!

@danimtb danimtb added this to the 1.14 milestone Mar 20, 2019
@danimtb danimtb assigned danimtb and unassigned uilianries Mar 20, 2019
@danimtb danimtb merged commit 75399fb into conan-io:develop Mar 20, 2019
2 checks passed
@ghost ghost removed the stage: review label Mar 20, 2019
@jakobjw
Copy link

@jakobjw jakobjw commented Apr 4, 2019

Typo in docs/methods.rst: "environemtn"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants