Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get commit message #1175

Merged
merged 1 commit into from May 3, 2019
Merged

Get commit message #1175

merged 1 commit into from May 3, 2019

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Mar 29, 2019

  • Both tools.Git and tools.SVN are able to retrieve the latest
    commit message aka log message

Related PR: conan-io/conan#4877

- Both tools.Git and tools.SVN are able to retrieve the latest
  commit message aka log message

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@ghost ghost assigned uilianries Mar 29, 2019
@ghost ghost added the stage: review label Mar 29, 2019
@uilianries uilianries mentioned this pull request Mar 29, 2019
5 tasks
@danimtb danimtb assigned danimtb and unassigned uilianries May 3, 2019
@danimtb danimtb added this to the 1.15 milestone May 3, 2019
danimtb
danimtb approved these changes May 3, 2019
@@ -618,7 +618,7 @@ This is a context manager that allows to temporary use environment variables for
with tools.environment_append({"MY_VAR": "3", "CXX": "/path/to/cxx", "CPPFLAGS": None}):
do_something()
The environment variables will be overridden if the value is a string, while it will be prepended if the value is a list.
The environment variables will be overridden if the value is a string, while it will be prepended if the value is a list.
Copy link
Member

@danimtb danimtb May 3, 2019

typo

Suggested change
The environment variables will be overridden if the value is a string, while it will be prepended if the value is a list.
The environment variables will be overridden if the value is a string, while they will be prepended if the value is a list.

@@ -1407,6 +1408,7 @@ Methods:
- **is_local_repository()**: Returns `True` if the remote is a local folder.
- **is_pristine()**: Returns `True` if there aren't modified or uncommitted files in the working copy.
- **get_repo_root()**: Returns the root folder of the working copy.
- **get_revision_message()**: Returns the latest log message
Copy link
Member

@danimtb danimtb May 3, 2019

dot

Suggested change
- **get_revision_message()**: Returns the latest log message
- **get_revision_message()**: Returns the latest log message.

@@ -1359,6 +1359,7 @@ Methods:
- **is_local_repository()**: Returns `True` if the remote is a local folder.
- **is_pristine()**: Returns `True` if there aren't modified or uncommitted files in the working copy.
- **get_repo_root()**: Returns the root folder of the working copy.
- **get_commit_message()**: Returns the latest log message
Copy link
Member

@danimtb danimtb May 3, 2019

dot

Suggested change
- **get_commit_message()**: Returns the latest log message
- **get_commit_message()**: Returns the latest log message.

@lasote lasote merged commit e23fb18 into conan-io:develop May 3, 2019
2 checks passed
@ghost ghost removed the stage: review label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants