Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated hello link to conan-io/hello repo #1269

Merged
merged 6 commits into from May 6, 2019

Conversation

Projects
None yet
4 participants
@danimtb
Copy link
Member

commented Apr 30, 2019

@ghost ghost assigned danimtb Apr 30, 2019

@ghost ghost added the stage: review label Apr 30, 2019

@danimtb danimtb removed their assignment Apr 30, 2019

@danimtb danimtb referenced this pull request Apr 30, 2019

Merged

Use conan-io/hello example for the new command #5069

5 of 5 tasks complete
@jgsogo

jgsogo approved these changes Apr 30, 2019

Copy link
Member

left a comment

I trust you these are all the memsharded/hello.git occurrences 😆

Show resolved Hide resolved reference/conanfile/methods.rst Outdated
@uilianries

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Why we didn't move to examples instead of creating a new project? Just curious.

@jgsogo

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@uilianries, have a look at the modified docs, it is useful to have a git repository with the project at the top level, easy to understand for beginners (easier Conan commands, no subfolders for scm,...).

@uilianries

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@jgsogo Yes, it sounds good. Thanks!

@ghost ghost assigned danimtb Apr 30, 2019

@danimtb

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

@jgsogo Don't trust me 😛
image

However, I realized there are at least two more memsharded repos referenced in the docs 🤣

@danimtb danimtb removed their assignment Apr 30, 2019

@jgsogo

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Those ones will be removed in the future...

@danimtb

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

sure!

Show resolved Hide resolved creating_packages/external_repo.rst Outdated
Show resolved Hide resolved creating_packages/getting_started.rst Outdated
Show resolved Hide resolved creating_packages/package_repo.rst Outdated
Show resolved Hide resolved creating_packages/external_repo.rst Outdated
@@ -33,7 +33,7 @@ You can also use the :ref:`tools.Git <tools_git>` class:
def source(self):
git = tools.Git(folder="hello")
git.clone("https://github.com/memsharded/hello.git", "static_shared")
git.clone("https://github.com/conan-io/hello.git", "master")

This comment has been minimized.

Copy link
@danimtb

danimtb May 3, 2019

Author Member

left this here as an example of checking-out a branch

"url": "https://github.com/memsharded/hello.git",
"revision": "static_shared"
"url": "https://github.com/conan-io/hello.git",
"revision": "master"

This comment has been minimized.

Copy link
@danimtb

danimtb May 3, 2019

Author Member

left this here as an example of checking-out a branch

Show resolved Hide resolved creating_packages/getting_started.rst Outdated
Show resolved Hide resolved creating_packages/package_repo.rst Outdated
"url": "https://github.com/memsharded/hello.git",
"revision": "static_shared"
"url": "https://github.com/conan-io/hello.git",
"revision": "master"

This comment has been minimized.

Copy link
@danimtb

danimtb May 3, 2019

Author Member

left this here as an example

@ghost ghost assigned danimtb May 3, 2019

danimtb added some commits May 3, 2019

@danimtb

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

Changes done!

@danimtb danimtb removed their assignment May 6, 2019

@jgsogo jgsogo merged commit 891b66d into conan-io:develop May 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.