Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated hello link to conan-io/hello repo #1269

Merged
merged 6 commits into from May 6, 2019

Conversation

@danimtb
Copy link
Member

@danimtb danimtb commented Apr 30, 2019

Docs for PR conan-io/conan#5069
Issue conan-io/conan#4916

@ghost ghost assigned danimtb Apr 30, 2019
@ghost ghost added the stage: review label Apr 30, 2019
@danimtb danimtb removed their assignment Apr 30, 2019
jgsogo
jgsogo approved these changes Apr 30, 2019
Copy link
Member

@jgsogo jgsogo left a comment

I trust you these are all the memsharded/hello.git occurrences 😆

reference/conanfile/methods.rst Outdated Show resolved Hide resolved
@uilianries
Copy link
Member

@uilianries uilianries commented Apr 30, 2019

Why we didn't move to examples instead of creating a new project? Just curious.

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Apr 30, 2019

@uilianries, have a look at the modified docs, it is useful to have a git repository with the project at the top level, easy to understand for beginners (easier Conan commands, no subfolders for scm,...).

@uilianries
Copy link
Member

@uilianries uilianries commented Apr 30, 2019

@jgsogo Yes, it sounds good. Thanks!

@ghost ghost assigned danimtb Apr 30, 2019
@danimtb
Copy link
Member Author

@danimtb danimtb commented Apr 30, 2019

@jgsogo Don't trust me 😛
image

However, I realized there are at least two more memsharded repos referenced in the docs 🤣

@danimtb danimtb removed their assignment Apr 30, 2019
@jgsogo
Copy link
Member

@jgsogo jgsogo commented Apr 30, 2019

Those ones will be removed in the future...

@danimtb
Copy link
Member Author

@danimtb danimtb commented Apr 30, 2019

sure!

creating_packages/external_repo.rst Outdated Show resolved Hide resolved
creating_packages/getting_started.rst Outdated Show resolved Hide resolved
creating_packages/package_repo.rst Outdated Show resolved Hide resolved
creating_packages/external_repo.rst Outdated Show resolved Hide resolved
@@ -33,7 +33,7 @@ You can also use the :ref:`tools.Git <tools_git>` class:
def source(self):
git = tools.Git(folder="hello")
git.clone("https://github.com/memsharded/hello.git", "static_shared")
git.clone("https://github.com/conan-io/hello.git", "master")
Copy link
Member Author

@danimtb danimtb May 3, 2019

left this here as an example of checking-out a branch

"url": "https://github.com/memsharded/hello.git",
"revision": "static_shared"
"url": "https://github.com/conan-io/hello.git",
"revision": "master"
Copy link
Member Author

@danimtb danimtb May 3, 2019

left this here as an example of checking-out a branch

creating_packages/getting_started.rst Outdated Show resolved Hide resolved
creating_packages/package_repo.rst Outdated Show resolved Hide resolved
"url": "https://github.com/memsharded/hello.git",
"revision": "static_shared"
"url": "https://github.com/conan-io/hello.git",
"revision": "master"
Copy link
Member Author

@danimtb danimtb May 3, 2019

left this here as an example

@ghost ghost assigned danimtb May 3, 2019
@danimtb
Copy link
Member Author

@danimtb danimtb commented May 3, 2019

Changes done!

@danimtb danimtb removed their assignment May 6, 2019
@jgsogo jgsogo merged commit 891b66d into conan-io:develop May 6, 2019
2 checks passed
@ghost ghost removed the stage: review label May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants