Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running commands specified as sequences #1385

Merged
merged 3 commits into from Jun 5, 2020
Merged

Support running commands specified as sequences #1385

merged 3 commits into from Jun 5, 2020

Conversation

jkuebart
Copy link
Contributor

@jkuebart jkuebart commented Aug 5, 2019

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2019

CLA assistant check
All committers have signed the CLA.

danimtb
danimtb approved these changes Aug 6, 2019
@danimtb
Copy link
Member

danimtb commented Aug 6, 2019

Hi @jkuebart and thanks for your contribution!

Please make sure to sign the CLA above in order to get approval to merge this PR.
Also, notice that changes in the documentation that are not related to changes for the next Conan release can go directly to the master branch.

Thanks!

@danimtb danimtb self-assigned this Aug 6, 2019
@jkuebart
Copy link
Contributor Author

jkuebart commented Aug 6, 2019

@danimtb Hi Daniel, thanks for your comments! Sorry, I only found the contribution guide to the main repo – should I rebase on top of master and change this PR's base branch?

This change should only go into the documentation if/when some form of conan-io/conan#5583 is accepted.

@danimtb
Copy link
Member

danimtb commented Aug 6, 2019

Sorry, I thought this was just a clarification message, not a PR associated with a new feature. In this case, pointing the PR to develop is the correct way. Thanks!

@jkuebart jkuebart changed the title Support running commands specified as a sequences Support running commands specified as sequences Aug 7, 2019
jgsogo
jgsogo approved these changes Jun 4, 2020
@jgsogo jgsogo added this to the 1.26 milestone Jun 4, 2020
@jgsogo jgsogo merged commit 808d0b3 into conan-io:develop Jun 5, 2020
2 checks passed
@jkuebart jkuebart deleted the feature/command-sequence branch Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants