Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging level names #1419

Merged
merged 3 commits into from Dec 5, 2019
Merged

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Sep 19, 2019

Related PR: conan-io/conan#5772

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@Minimonium
Copy link
Contributor

@Minimonium Minimonium commented Sep 21, 2019

It'd be cool to have some examples of what we can expect to get from these log levels.

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Nov 6, 2019

Yes, @Minimonium , it would be nice, but I think that the two files modified in this PR (up to now) aren't the place to add this information... those are sections inside already long files.

I would suggest improving the Logging one (https://docs.conan.io/en/latest/mastering/logging.html): there we talk about CONAN_TRACE_FILE but we say nothing about the logging level and it would probably make a lot of sense, wdyt @danimtb ?

@danimtb
Copy link
Member

@danimtb danimtb commented Nov 6, 2019

Yes, makes sense to have that in the logging one

@jgsogo jgsogo added this to the 1.21 milestone Nov 7, 2019
@uilianries
Copy link
Member Author

@uilianries uilianries commented Nov 7, 2019

Yes, @Minimonium , it would be nice, but I think that the two files modified in this PR (up to now) aren't the place to add this information... those are sections inside already long files.

I gonna open a new issue to introduce those examples.

@lasote lasote merged commit 1cfdaae into conan-io:develop Dec 5, 2019
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants