Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared_library_package_id() #1442

Merged
merged 9 commits into from Oct 16, 2019
Merged

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Oct 15, 2019

Docs for https://github.com/conan-io/conan/pull/5893/files

Copy link
Contributor

@lasote lasote left a comment

I think we can explain better

reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
memsharded and others added 8 commits Oct 15, 2019
Co-Authored-By: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com>
Co-Authored-By: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com>
Co-Authored-By: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com>
Co-Authored-By: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com>
Co-Authored-By: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com>
Co-Authored-By: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com>
Co-Authored-By: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com>
@memsharded
Copy link
Member Author

@memsharded memsharded commented Oct 15, 2019

Suggestions merged and link added. Did you mean that it needs some improvements besides the ones you suggested, or the improvements are your suggestions?

lasote
lasote approved these changes Oct 16, 2019
@lasote
Copy link
Contributor

@lasote lasote commented Oct 16, 2019

It is good now.

@lasote lasote merged commit bc3390f into conan-io:develop Oct 16, 2019
2 checks passed
@memsharded memsharded deleted the feature/shared_libraries_id branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants